Update Docker Build Version for Image Scan Workflow #910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzhlogin
approved these changes
Oct 16, 2024
mxiamxia
approved these changes
Oct 16, 2024
yiyuan-he
commented
Oct 21, 2024
| uses: docker/setup-buildx-action@v3 | ||
| with: | ||
| driver-opts: image=moby/buildkit:v0.15.1 | ||
| if: ${{ matrix.os == 'ubuntu-latest' }} |
Contributor
Author
There was a problem hiding this comment.
IMPORTANT:
Do not include this if condition. It is unnecessary and will cause the Docker build to be skipped since matrix.os is not defined here.
See issue and fix that this if statement cause here:
yiyuan-he@0fdbf83
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Docker Build Version for Image Scan Workflow.
Context can be found in this MCM: https://mcm.amazon.dev/cms/MCM-112315558/execution/step/9de5087f-2c46-42b8-b760-a9ce99b569df
Previous Patch PR (merged): #909
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.